Build failure

The "Native Policy Plumbing" smoke tests (Electron, Windows) fail in their before all hook with ENOENT: no such file or directory, open '...\VSCode-win32-x64\resources\app\product.json'. Both Policy Plumbing tests throw before any assertion runs, failing the Windows Electron smoke stage on main.

Root cause

test/smoke/src/areas/policy/nativePolicy.ts resolved the built product manifest on Windows by joining resources/app/product.json onto path.dirname(getBuildElectronPath(options.codePath)) — effectively the root of the build output. However, the Windows built app nests its payload inside a subdirectory (e.g. VSCode-win32-x64). getBuildElectronPath itself accounts for this: for win32 it uses the findFilePath helper in test/automation/src/electron.ts, which searches one level of subdirectories for resources/app/product.json. The fixture bypassed that logic and assumed the file lived directly under the root, so fs.readFileSync hit a non-existent path and threw.

How the fix works

Added an exported getBuildProductPath(root) helper in test/automation/src/electron.ts that resolves product.json per-platform, reusing the existing findFilePath subdirectory search on win32 (the same mechanism getBuildElectronPath/getBuildVersion already use). nativePolicy.ts now calls getBuildProductPath(options.codePath) instead of hand-rolling the path, so the Windows nested layout is handled correctly and darwin/linux behavior is preserved. This corrects the invalid path producer rather than guarding the consumer or swallowing the error.

Rollback evaluation

Recommendation: Do not roll back. Public culprit: PR #335107 (commit 644fe2ac), which introduced the fixture. The regression is isolated to new test-fixture path resolution with no product/runtime/schema impact, and this fix-forward is a small, bounded correction that reuses existing, proven path-resolution logic. Reverting would only remove the new smoke coverage. Owners to consult: @rwoll

Validation

Source inspection only. getBuildElectronPath (win32) and getBuildVersion (win32) already rely on findFilePath to locate resources/app/product.json within a subdirectory of the build root, confirming the nested layout; the new helper reuses the identical resolution. TypeScript type checking / smoke test execution could not be run in this environment (the tsc and build tooling were unavailable to the agent).

Risk

Low. The change is confined to test automation/smoke code, adds a helper that mirrors existing behavior, and leaves the non-Windows paths functionally unchanged.

Recommended reviewer

Recommended owner: @rwoll

Fixes microsoft/vscode-engineering#3813

Generated by build-fix · opus48 · 168.9 AIC · ⌖ 19.1 AIC · ⊞ 11.7K · ◷