{{ message }}
Repository navigation
Prevent unbounded terminal output buffering in the main process - #334913
Closed
Ulugbek Abdullaev (ulugbekna) with Copilot wants to merge 2 commits into
Closed
Ulugbek Abdullaev (ulugbekna) with Copilot wants to merge 2 commits into
Ulugbek Abdullaev (ulugbekna) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: ulugbekna <16353531+ulugbekna@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix main process leaks from terminal PTY output
Prevent unbounded terminal output buffering in the main process
Sep 7, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localPtyeagerly buffers terminal events that renderers consume through a direct pty-host MessagePort instead. Those buffers never drain, causing output-proportional main-process heap growth and eventual OOM.localPty, using a typed shared event list.onPtyHost*events; leave direct-channel delivery and global IPC semantics unchanged.ProxyChannel.fromService(PtyHostService)buffersonProcessDataviaEvent.bufferfor alocalPtylistener that never attaches #334837