{{ message }}
agentHost: Respect telemetry disablement from process launch - #330929
Merged
roblourens merged 10 commits intoAug 16, 2026
Conversation
Send each client's effective telemetry level with initialize and reconnect so the host applies consent before connection telemetry or queued actions. Keep the host disabled until a client level arrives, and propagate process-level restrictions to generic remote telemetry.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Forwards effective telemetry consent during Agent Host handshakes and applies it before connection telemetry.
Changes:
- Adds telemetry level to initialize/reconnect metadata.
- Gates Agent Host telemetry until consent is received.
- Adds handshake and telemetry restriction tests.
Show a summary per file
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 2
- Review effort level: Balanced
Keep fail-closed startup explicit to the production factory while preserving the established constructor behavior used by isolated Agent Host components and tests.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep seeded root configuration from enabling telemetry before initialize or reconnect provides a client telemetry level. Preserve existing direct-construction defaults for isolated callers and tests.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Start controlled Agent Host processes with the launcher's effective telemetry level so opted-in clients retain early diagnostics while opted-out clients disable telemetry before startup. Keep initialize and reconnect updates as a monotonic multi-client clamp across local, remote-server, SSH, WSL, and CLI-supervised hosts.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
changed the title
Resolve Agent Host handshake metadata conflicts by carrying both effective telemetry consent and usage-gated client identity through initialize and reconnect.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Include the link presentation provider extension point generated by hygiene after merging origin/main.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the shared process telemetry service when launching SSH and WSL Agent Hosts instead of threading the telemetry level through renderer IPC contracts.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
August 15, 2026 15:54
roblourens
requested review from
TylerLeonhardt and
Alex Ross (alexr00)
as code owners
August 15, 2026 15:54
roblourens
enabled auto-merge (squash)
August 15, 2026 15:54
…ry-disablement-investigation
Leave the stale generated cache synchronization to a dedicated change instead of carrying it in the Agent Host telemetry PR.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
left a comment
Dmitriy Vasyura (dmitrivMS)
left a comment
Collaborator
There was a problem hiding this comment.
AI Review: Reviewed the launch-time and client-handshake telemetry clamps across local, remote, SSH, WSL, and CLI paths.
Clamp independent launch telemetry sources, fail closed for malformed supplied consent, preserve legacy omission behavior, and remove redundant telemetry plumbing identified during review.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Vijay Upadya (vijayupadya)
approved these changes
Aug 16, 2026
roblourens
deleted the
roblou/agents/telemetry-disablement-investigation
branch
August 16, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
off/crash/error/alltelemetry levelWhy
Agent Hosts need two properties at once: telemetry-disabled clients must be respected before any Agent Host event can leave the process, while opted-in clients should retain early startup and connection diagnostics. Launcher-time propagation provides both. Controlled launchers now pass their actual effective level before Agent Host telemetry initializes; initialize/reconnect then only make the running host more restrictive as clients connect.
Direct or externally launched Agent Hosts continue to start from their own configured telemetry level. SSH/WSL custom-command overrides receive the effective level through an inherited Agent Host environment variable. OTel behavior is intentionally unchanged.
Validation
npm run compilenpm run hygienenpm run typecheck-clientcargo check --manifest-path cli/Cargo.tomlcargo test --manifest-path cli/Cargo.toml agent_hostrustfmt --check(Written by Copilot)