Update error message for unsupported skill attributes by TheNotary · Pull Request #328318 · microsoft/vscode · GitHub
Skip to content

Update error message for unsupported skill attributes - #328318

Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
microsoft:mainfrom
TheNotary:patch-1
Aug 26, 2026
Merged

Update error message for unsupported skill attributes#328318
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
microsoft:mainfrom
TheNotary:patch-1

Conversation

@TheNotary

Copy link
Copy Markdown
Contributor

I'd like to speak with an agent about this please.

I'd like to speak with an agent about this please.
Copilot AI review requested due to automatic review settings July 30, 2026 23:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates validation messaging to correctly associate unsupported attributes with VS Code skills rather than agents.

Changes:

  • Corrected the localized unsupported skill attribute message.

@TheNotary

Copy link
Copy Markdown
Contributor Author

@TheNotary

Copy link
Copy Markdown
Contributor Author

Copilot can you do this or not buddy?

@dmitrivMS

Copy link
Copy Markdown
Collaborator

The change is incomplete and/or incorrect and does not seem to solve a specific problem.

@TheNotary

Copy link
Copy Markdown
Contributor Author

The change is incomplete and/or incorrect and does not seem to solve a specific problem.

Hi Dmitriy Vasyura (@dmitrivMS). Was this review manual or automated?

If manual, did you take a peek at the diff, it tells the story best, especially if you compare the changed line with line 311. This is a one-word change, where it seems a copy/ paste error occurred. My take is that the author meant to copy the string from the agents error message to use for the skills error message, but the word agents never got updated correctly to the word skills.

If automated, that's exciting, but is your automation pulling in the commentary from Copilot's first post? Its summary is better than what I would have generated or what I put in the prior paragraph just now really :).

@dmitrivMS

Copy link
Copy Markdown
Collaborator

Hi, I reviewed, commented, and closed, not agent.
I did look at the diff. There are other strings that mention "agents", so I think the change is inconsistent.

@TheNotary

Copy link
Copy Markdown
Contributor Author

I see the miscommunication (as I get better at sharing context with the harness, I'm worried I'm getting rusty at sharing it with actual humans 😅).

Below is a screenshot of VS Code surfacing the error that this PR updates. I added a key that isn't listed in the Skill schema, and can see the error message when hovering over the invalid key.

image

A Skill file is open, but the error message suggests that it's interpreting the SKILL.md file as an AGENT file (e.g. foo.agent.md). This confused me and created a suspicion that VS Code wasn't correctly processing the schema for Skill files. This led to a fun bug hunt adventure/ distraction into VS Code that went as far as discovering it was just a simple typo.

That word should be corrected to accurately indicate that the file in question is correctly being interpreted as a Skill file and not an Agent file, right?

@dmitrivMS

Copy link
Copy Markdown
Collaborator

TheNotary Thanks a lot for the explanation and proving me wrong!

@saroasid-web

Copy link
Copy Markdown

يجب تغير الوجه لي الاتنين

@saroasid-web

Copy link
Copy Markdown

والرساله تم ارسلها خطأ

@saroasid-web Saswwo (saroasid-web) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ارسلتها خطاء

@saroasid-web

Copy link
Copy Markdown

تم

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) merged commit 8aa4172 into microsoft:main Aug 26, 2026
27 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.136.0 milestone Aug 26, 2026
@TheNotary

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants