Fix for missing terminal suggest symbol icon css mappings by EmrecanKaracayir · Pull Request #293158 · microsoft/vscode · GitHub
Skip to content

Fix for missing terminal suggest symbol icon css mappings - #293158

Merged
Megan Rogge (meganrogge) merged 5 commits into
microsoft:mainfrom
EmrecanKaracayir:emrecankaracayir/terminal-symbol-icons
Jul 29, 2026
Merged

Fix for missing terminal suggest symbol icon css mappings#293158
Megan Rogge (meganrogge) merged 5 commits into
microsoft:mainfrom
EmrecanKaracayir:emrecankaracayir/terminal-symbol-icons

Conversation

@EmrecanKaracayir

Copy link
Copy Markdown
Contributor

Fixes: #293157

@EmrecanKaracayir

Copy link
Copy Markdown
Contributor Author

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing CSS mappings for terminal symbol icons in the suggest widget, addressing issue #293157 where custom theme token colors for terminal symbols were not being applied.

Changes:

  • Added CSS mappings for 11 new terminal symbol icons (file, folder, symbolic links, commit, branch, tag, stash, remote, pull request variants)
  • Reorganized existing CSS rules to group related icon types together

@EmrecanKaracayir

Copy link
Copy Markdown
Contributor Author

Order of the CSS rules changed (no deletion made) to make it more inline with the _kindToIconMap enum in src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts.

Emrecan Karaçayır and others added 2 commits February 5, 2026 20:43
…/terminalSymbolIcons.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@meganrogge Megan Rogge (meganrogge) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) March 24, 2026 21:28
@alexr00 Alex Ross (alexr00) removed this from the 1.114.0 milestone Mar 30, 2026
@EmrecanKaracayir

Copy link
Copy Markdown
Contributor Author

Why this isn't merging?

@vs-code-engineering

Copy link
Copy Markdown
Contributor

@meganrogge
Megan Rogge (meganrogge) merged commit a9c8db2 into microsoft:main Jul 29, 2026
29 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.132.0 milestone Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal suggest widget missing symbol icon color matchings

7 participants