{{ message }}
Repository navigation
Mark variables in zsh integration functions as local - #290298
Merged
Anthony Kim (anthonykim1) merged 6 commits intoOct 15, 2026
Merged
Anthony Kim (anthonykim1) merged 6 commits into
Anthony Kim (anthonykim1) merged 6 commits into
Conversation
…lute the global namespace
Ladislau Szomoru (lszomoru)
requested a review
from Anthony Kim (anthonykim1)
January 26, 2026 06:47
Ladislau Szomoru (lszomoru)
assigned
Anthony Kim (anthonykim1) and unassigned
Ladislau Szomoru (lszomoru)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused declarations prevent unintended globals without changing the integration logic.
0 open findings
What changed in this PR
Marks temporary zsh shell-integration variables as function-local, preventing warn_create_global warnings and global-state pollution.
Changes:
- Localizes the environment-cache loop index.
- Localizes environment-reporting loop and value variables.
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Anthony Kim (anthonykim1)
approved these changes
Oct 15, 2026
Anthony Kim (anthonykim1)
left a comment
Anthony Kim (anthonykim1)
left a comment
Contributor
There was a problem hiding this comment.
thank you!
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
October 15, 2026 15:39
roblourens
approved these changes
Oct 15, 2026
roblourens
approved these changes
Oct 15, 2026
Nick Trogh (ntrogh)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run zsh with
setopt warn_create_globaland got annoyed at the warnings.I moved this updated file into my
resources\app\out\vs\workbench\contrib\terminal\common\scriptsfolder of my vscode instance and verified I no longer got warnings about global variables and observed no strange behavior.