Use app.dock.hide when connecting to an existing instance by JBlitzar · Pull Request #259352 · microsoft/vscode · GitHub
Skip to content

Use app.dock.hide when connecting to an existing instance#259352

Closed
JBlitzar wants to merge 3 commits intomicrosoft:mainfrom
JBlitzar:main
Closed

Use app.dock.hide when connecting to an existing instance#259352
JBlitzar wants to merge 3 commits intomicrosoft:mainfrom
JBlitzar:main

Conversation

@JBlitzar
Copy link
Copy Markdown

@JBlitzar JBlitzar commented Aug 2, 2025

As discussed in #258824 (comment)

(and previously #131213 (comment))

Calls app.dock.hide() after another running instance is detected.

@deepak1556

@deepak1556
Copy link
Copy Markdown
Collaborator

@bpasero
Copy link
Copy Markdown
Member

bpasero commented Aug 4, 2025

I like the idea of trying this again, but shouldn't we just restore how it used to be before we removed it? I think I was calling it at a very early point.

@bpasero
Copy link
Copy Markdown
Member

bpasero commented Aug 5, 2025

@bpasero bpasero closed this Aug 5, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants