{{ message }}
Repository navigation
Fix Python raw XML byte-stream regression for legacy bytes encoding - #12326
Merged
Merged
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:python
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Python emitter change causing XML content loss
Fix Python raw XML byte-stream regression for legacy bytes encoding
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow compatibility fix preserves custom-encoding fallback and includes targeted regression coverage, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Restores Python’s legacy raw-byte XML response contract, addressing the compatibility regression described in #12325.
Changes:
- Recognizes
"bytes"encoding while preserving fallback for unsupported encodings. - Adds emitter and Python regression coverage for sync/async streaming and complete XML preservation.
- Documents the fix in a changelog entry.
| File | Description |
|---|---|
| packages/http-client-python/tests/unit/test_raw_bytes_xml.py | Tests signatures, default streaming, and XML preservation. |
| packages/http-client-python/emitter/test/types.test.ts | Covers legacy bytes encoding and custom-encoding fallback. |
| packages/http-client-python/emitter/test/test-host.ts | Registers the HTTP library for tests. |
| packages/http-client-python/emitter/test/emitter.test.ts | Tests emission from a legacy XML response specification. |
| packages/http-client-python/emitter/src/types.ts | Adds "bytes" to supported bytes encodings. |
| .chronus/changes/copilot-fix-python-emitter-xml-bug-2026-9-21-8-26-3.md | Records the compatibility fix. |
Review effort: Balanced
Yuchao Yan (msyyc)
marked this pull request as ready for review
October 21, 2026 08:40
Yuchao Yan (msyyc)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Libba Lawrence (l0lawrence),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 21, 2026 08:40
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
|
You can try these changes here |
Libba Lawrence (l0lawrence)
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New TCGC
wireTypemetadata caused legacy@encode("bytes")XML responses to becomestrinstead of byte iterators. XML scalar deserialization then discarded child elements and attributes."bytes"as a supported bytes encoding, preserving syncIterator[bytes], asyncAsyncIterator[bytes], and default streaming. Genuinely unsupported/custom encodings retain the wire-type fallback.