{{ message }}
Fix context menu crash after split pane submenu - #20612
Open
OmarMashal (OmarMashal0) wants to merge 1 commit into
Open
Fix context menu crash after split pane submenu#20612OmarMashal (OmarMashal0) wants to merge 1 commit into
OmarMashal (OmarMashal0) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your AI wrote this PR, right? Can you ask it to minimize the diff please? It's a bug fix after all. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of the Pull Request
Fixes the context menu crash reported in #20570 after interacting with the Split pane submenu and collapsing/re-expanding the root menu.
This replaces the nested
CommandBarFlyoutchild menus with standardMenuFlyoutcontrols.References and Relevant Issues
Closes #20570
Related: #20332
The repro from #20332 also no longer occurs on the patched build.
Detailed Description of the Pull Request / Additional comments
CommandBarFlyoutmenus withMenuFlyout.MenuFlyoutSubItemfor duplicate/profile split entries, with an explicitAutomaticoption followed by the directional split options.CommandBarFlyout.Automaticlabel.Validation Steps Performed
ContextMenuUsesMenuFlyoutsForSplitAndSwapPane: 1 passed, 0 failed.TabTests: 22 passed, 0 failed, 0 blocked, 0 skipped.CascadiaPackageDebug x64: built successfully (0 errors).CascadiaPackageRelease x64: built successfully (0 errors).Video
issues_20570_20332.mp4
PR Checklist