{{ message }}
Repository navigation
Fix wildcard imports from local __builtins__.pyi - #11856
Open
King Star (jstar0) wants to merge 1 commit into
Open
King Star (jstar0) wants to merge 1 commit into
King Star (jstar0) wants to merge 1 commit into
Conversation
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11855
When a local
__builtins__.pyiwildcard-imports project modules, those modules can be bound while the custom builtins file is still binding. They can then keep that binding without the custom builtins scope, causing names provided by the stub to be reported as undefined.Rebind a file when its existing binding used a different builtins scope from the completed implicit import chain. Add a regression covering two local modules and names exposed through the custom builtins stub.
Verification:
pnpm --dir packages/pyright-internal exec jest src/tests/typeEvaluator8.test.ts --runInBand --forceExitpnpm --dir packages/pyright-internal exec jest src/tests/sourceFile.test.ts --runInBand --forceExitpnpm --dir packages/pyright-internal exec jest src/tests/fourSlashRunner.test.ts --runInBand --forceExit -t completions.builtinOverridepnpm --dir packages/pyright-internal run build