Fix `proxy_view` with facade-aware overloads by mingxwa · Pull Request #347 · microsoft/proxy · GitHub
Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Fix proxy_view with facade-aware overloads#347

Merged
mingxwa merged 1 commit into
microsoft:mainfrom
mingxwa:user/mingxwa/facade-aware-proxy-view
Sep 1, 2025
Merged

Fix proxy_view with facade-aware overloads#347
mingxwa merged 1 commit into
microsoft:mainfrom
mingxwa:user/mingxwa/facade-aware-proxy-view

Conversation

@mingxwa

@mingxwa mingxwa commented Sep 1, 2025

Copy link
Copy Markdown

Changes

  • Fixed the definition of details::observer_indirect_conv to honor the facade-aware overloads without early substitution.
  • Refactored details::observer_facade_conv_impl and details::observer_facade_refl_impl accordingly with composite_t.
  • Added a unit test case for this scenario.

Resolves #346

@DannyBaobei

Copy link
Copy Markdown

@mingxwa mingxwa merged commit 7f11ac5 into microsoft:main Sep 1, 2025
10 checks passed
@mingxwa mingxwa deleted the user/mingxwa/facade-aware-proxy-view branch September 1, 2025 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to declare a self implement binary operation like "bool AreEqual(const Point_2& other, double tol=1.0e-6)"?

3 participants