fix(cli): accept install-browser --no-shell by yury-s · Pull Request #42871 · microsoft/playwright · GitHub
Skip to content

fix(cli): accept install-browser --no-shell - #42871

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42804
Sep 23, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42804

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • playwright-cli install-browser --no-shell was rejected with Unknown option: --shell: minimist parses it as { shell: false }, but the command declares no-shell. Flag validation now accepts negated flags declared as no-*.
  • Drop the unused noShell option from installBrowsers.

Fixes #42804

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8704 passed, 1474 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

@yury-s
Yury Semikhatsky (yury-s) merged commit 0406789 into microsoft:main Sep 23, 2026
45 of 46 checks passed
Yury Semikhatsky (yury-s) added a commit to microsoft/playwright-cli that referenced this pull request Sep 28, 2026
## Fixes

- `run-code` scripts can use timers, `fetch`, `URL`, `Buffer`, `crypto`,
`AbortController` and `TextEncoder`/`TextDecoder`; `require` and
`process` stay unavailable
([#471](#471)).
([microsoft/playwright#42975](microsoft/playwright#42975))
- `find --filename=results.md` saves matches to a file when a query
produces too many of them
([microsoft/playwright#42077](microsoft/playwright#42077)).
([microsoft/playwright#42968](microsoft/playwright#42968))
- `goto` and `reload` report a dialog opened during page load instead of
timing out
([microsoft/playwright#42817](microsoft/playwright#42817)).
([microsoft/playwright#42908](microsoft/playwright#42908))
- The session no longer crashes when the browser is closed during a
download
([microsoft/playwright#42831](microsoft/playwright#42831)).
([microsoft/playwright#42922](microsoft/playwright#42922))
- `install-browser --no-shell` is accepted instead of failing with
`Unknown option: --shell`
([microsoft/playwright#42804](microsoft/playwright#42804)).
([microsoft/playwright#42871](microsoft/playwright#42871))
- `webmcp-call` no longer runs a tool in a stale tab or frame
([microsoft/playwright#42816](microsoft/playwright#42816)).
([microsoft/playwright#42821](microsoft/playwright#42821))
- `webmcp-call` works with Chromium 155+.
([microsoft/playwright#42915](microsoft/playwright#42915))
- Snapshots quote accessible names that look like regexes, e.g.
`"/home/"`
([microsoft/playwright#42807](microsoft/playwright#42807)).
([microsoft/playwright#42811](microsoft/playwright#42811))
- The bundled skill only preapproves Playwright commands instead of any
`npm` and `npx` command
([microsoft/playwright#42745](microsoft/playwright#42745)).
([microsoft/playwright#42789](microsoft/playwright#42789))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI]: install-browser --no-shell is rejected with "Unknown option: --shell"

2 participants