{{ message }}
fix(routing): match ws(s) baseURL rewrite case-insensitively - #41557
Merged
Simon Knott (Skn0tt) merged 1 commit intoJul 1, 2026
Merged
Conversation
toWebSocketBaseUrl() only rewrote http(s) to ws(s) when the scheme was lowercase, so a baseURL like 'HTTP://x.com' was left untouched and routeWebSocket()/waitForEvent('websocket') would never match. Schemes are case-insensitive per RFC 3986, and the rest of urlMatch.ts already treats them that way, so do the same here.
Pavel Feldman (pavelfeldman)
approved these changes
Jul 1, 2026
Contributor
Contributor
Test results for "tests 1"4 flaky49225 passed, 1163 skipped Merge workflow run. |
Member
|
@microsoft-github-policy-service rerun |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toWebSocketBaseUrlonly rewrote an http(s)baseURLto ws(s) when the scheme happened to be lowercase, so something likebaseURL: 'HTTP://x.com'was left as-is androuteWebSocket()/waitForEvent('websocket')would just never match. URI schemes are case-insensitive per RFC 3986, and the rest ofurlMatch.tsalready treats them that way (see the origin handling a few lines down), so this just brings the ws(s) rewrite in line with that. Added a test with an uppercaseHTTP://baseURL that fails on main and passes with the fix.