fix image check bug by Binyang2014 · Pull Request #20 · microsoft/openpai-runtime · GitHub
Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

fix image check bug#20

Merged
Binyang2014 merged 4 commits into
masterfrom
binyli/dev
Aug 7, 2020
Merged

fix image check bug#20
Binyang2014 merged 4 commits into
masterfrom
binyli/dev

Conversation

@Binyang2014

@Binyang2014 Binyang2014 commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Image checker will try to check image with best effort. If registry return unexpected code such as 5xx/429, image checker will abort. We only failed the image checker when we make sure the image is not exist or authentication failed.

Fix: #17

@Binyang2014 Binyang2014 marked this pull request as ready for review August 4, 2020 12:43
@Binyang2014 Binyang2014 requested a review from abuccts August 4, 2020 12:43
@Binyang2014 Binyang2014 merged commit b9b91cd into master Aug 7, 2020
@Binyang2014 Binyang2014 deleted the binyli/dev branch August 7, 2020 11:00
@Binyang2014

Copy link
Copy Markdown
Collaborator Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image check doesn't handle 429 response correctly

2 participants