{{ message }}
Repository navigation
Fix TCP console restore status wait timeout - #530
Merged
Pedro Henrique Penna (ppenna) merged 3 commits intoOct 14, 2026
Merged
Pedro Henrique Penna (ppenna) merged 3 commits into
Pedro Henrique Penna (ppenna) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new logic breaks repeated waits, and the regression test does not reliably enforce the triggering receive layout.
2 open findings
What changed in this PR
Fixes TCP console restore-status waits when the response was consumed alongside a snapshot milestone.
Changes:
- Returns when a status query was previously observed.
- Adds a regression test for coalesced milestone/status output.
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wait_for_time_abi_status returned on any status query ever observed, so the next-query contract was lost. The snapshot-tier caller now captures the status count before its milestone reads and waits since that baseline. The regression test reads its bytes in one scripted chunk so the query is always consumed by the milestone read. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Pedro Henrique Penna (ppenna)
merged commit Oct 14, 2026
4acf7eb
into
microsoft:dev
29 checks passed
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
A restore status query can be received in the same TCP read as an earlier snapshot milestone. The monitor validates it, but the subsequent wait used the current query count as its baseline and timed out waiting for a second query.
Change
Return immediately when the monitor has already observed a status query. Added a regression test covering a restore response consumed during milestone waiting.
Testing
git diff --checkRegression test: fails on base twice (/TimeoutError: nvx-time status did not exit within 0.2s on the TCP console/), passes on fix twice (
python -m unittest scripts.test_time_abi.RunnerWiringTests.test_tcp_console_status_query_consumed_with_restore_milestone)Fixes #504