{{ message }}
fix: swallow resize() errors after PTY exit on Windows and Unix#901
Open
euxaristia wants to merge 2 commits into
Open
fix: swallow resize() errors after PTY exit on Windows and Unix#901euxaristia wants to merge 2 commits into
euxaristia wants to merge 2 commits into
Conversation
Silently ignore resize calls after the PTY process has exited instead of throwing 'Cannot resize a pty that has already exited'. This prevents crashes on Windows with Node.js v22 when a resize is attempted after the process has exited. Fixes microsoft#827
pty.resize() throws an error with message 'ioctl(2) failed, EBADF' when the PTY file descriptor has already been closed (e.g. the process exited and the fd was destroyed before a resize event fired). Catch EBADF by both error code and message and silently return instead of crashing.
euxaristia
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resize()calls after the PTY process has already exited instead of throwing'Cannot resize a pty that has already exited'(Windows)EBADFerrors onresize()when the PTY file descriptor is already closed and silently return instead of crashing (Unix)Fixes #827
Details
Windows: The native conpty
_exitCodeguard previously threw an error, which could crash the host process if the caller didn't wrapresize()in a try/catch. This is a race condition that's more likely to surface on Node.js v22 due to timing changes in its stream/event loop internals.Unix:
pty.resize()throws'ioctl(2) failed, EBADF'when the PTY file descriptor has already been closed before a resize event fires. The fix catchesEBADFby both error code and message and silently returns.Test plan
EBADFis no longer thrown