SystemVerilog: Adding better syntax highlighting for primitive table definitions by sw23 · Pull Request #165 · microsoft/monaco-languages · GitHub
Skip to content
This repository was archived by the owner on Nov 5, 2021. It is now read-only.

SystemVerilog: Adding better syntax highlighting for primitive table definitions - #165

Merged
Alexandru Dima (alexdima) merged 1 commit into
microsoft:mainfrom
sw23:sv_table_highlight_update
Oct 11, 2021
Merged

Alexandru Dima (alexdima) merged 1 commit into
microsoft:mainfrom
sw23:sv_table_highlight_update

Conversation

@sw23

@sw23 Spencer Williams (sw23) commented Oct 10, 2021 •

Copy link
Copy Markdown
Contributor

Adding better syntax highlighting for user-defined primitive tables, which have their own list of symbols defined by the language (0, 1, x, ?, b, -, *, r, f, p, n). Currently the identifiers and numbers are getting highlighted which looks OK, but adding a uniform style looks better.

Before:
sv_table_before

After:
sv_table_after

I'm participating in Hacktoberfest, so if this PR looks good and you don't mind, could you add the hacktoberfest-accepted label to it? Thanks a lot!

@alexdima

Copy link
Copy Markdown
Member

@sw23

Spencer Williams (sw23) commented Oct 16, 2021 •

Copy link
Copy Markdown
Contributor Author

Alexandru Dima (@alexdima) it looks like for this PR to be counted for Hacktoberfest it needs the 'hacktoberfest-accepted' label added, since the project doesn't have 'hacktoberfest' topic added. I confirmed it's not showing up in my list of completed PRs for Hacktoberfest. Would you mind adding the hacktoberfest-accepted label to this and my other PR, if possible? Thanks a lot!
Other PR: #163

@alexdima

Copy link
Copy Markdown
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants