{{ message }}
Repository navigation
feat(ipynb): render code cell outputs (streams, errors, text results) - #2534
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
Notebooks carry their recorded results in cell outputs, but the converter dropped them entirely: only sources survived. Render the text-bearing outputs after each code cell - stdout/stderr streams and plain-text results as fenced blocks, error outputs with their traceback (or ename/evalue when no traceback was recorded). Image/HTML outputs are left out. Fixes microsoft#2285 Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
Output is put inside a fixed triple-backtick fence without checking its contents. A cell that prints a line containing three backticks will close the fence early and corrupt the rest of the Markdown. Could this pick a fence longer than any backtick run in the output?
…tent Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Author
Sylvester Kaczmarek (sylvesterkaczmarek)
approved these changes
Sep 19, 2026
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
Rechecked b24f82b. The fence is now chosen one backtick longer than the longest run in the cell/output content, so embedded triple-backtick (or longer) runs cannot terminate the block early. The regression covers the exact case I raised, and the focused notebook-output suite passes 4/4 locally. My concern is resolved.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2285.
Code cell outputs were dropped entirely; only the sources converted. This renders the text-bearing ones after each cell:
Binary outputs (images, HTML) are intentionally not handled. Cells without outputs are byte-for-byte unchanged (the empty-render join is skipped), so existing conversions do not change shape.
3 new tests (stream+error, text result, no-output cell unchanged); the first two fail on main. Notebook-related suites green (9 passed).