{{ message }}
Repository navigation
fix(rss): emit item and entry links as heading anchors - #2525
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
RSS items and Atom entries carry a <link> (or Atom <link href>), but the converter never read it: the markdown ended up with bare titles and no way to reach the post. Emit the title as a markdown link to the resolved URL instead (relative hrefs resolve against the feed URL). Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
When an item has a link this drops the heading marker. heading starts as ## title, then gets replaced with title, so linked RSS/Atom entries stop being headings. Looks like that assignment just needs to keep the ## prefix.
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Author
Sylvester Kaczmarek (sylvesterkaczmarek)
approved these changes
Sep 19, 2026
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
Rechecked 40d6912. The linked Atom entry now keeps the ## heading marker while wrapping the title in the anchor, so linked items remain level-2 headings. That resolves the formatting issue I raised.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RSS and Atom converters read the feed-level link but never the per-item one, so every entry came out as a bare heading with no URL to reach. Titles now render as markdown links to the resolved item URL (Atom
<link href>attribute; RSS<link>text; relative hrefs resolve against the feed URL when the document URI is known).No output change for feeds whose items have no link element. Existing RSS suite green (107 passed).