{{ message }}
Conversation
akaroml
requested changes
Sep 7, 2017
| <version>0.0.1-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
| <properties> | ||
| <base.name>Vscode Java Debug Server</base.name> |
Member
There was a problem hiding this comment.
Java Debug Server for Visual Studio Code
| </parent> | ||
| <artifactId>com.microsoft.java.debug</artifactId> | ||
| <packaging>eclipse-plugin</packaging> | ||
| <name>${base.name} :: Debug</name> |
| </artifactItem> | ||
| <artifactItem> | ||
| <groupId>com.github.olivergondza</groupId> | ||
| <artifactId>maven-jdk-tools-wrapper</artifactId> |
Member
There was a problem hiding this comment.
What's this? I didn't see this in the original pom file.
| <artifactId>tools</artifactId> | ||
| <version>1.8</version> | ||
| <scope>system</scope> | ||
| <systemPath>${java.home}/../lib/tools.jar</systemPath> |
Member
There was a problem hiding this comment.
Is the maven-jdk-tools-wrapper for Maven to work with tools.jar?
Member
There was a problem hiding this comment.
If the maven-jdk-tools-wrapper is used, do we still need to include tools.jar here?
From the link below, it seems unnecessary.
https://stackoverflow.com/questions/35240134/declare-maven-dependency-on-tools-jar-to-work-on-jdk-9/35244168#35244168
yaohaizh
reviewed
Sep 8, 2017
Contributor
There was a problem hiding this comment.
Do we really need this extension?
andxu
added a commit
that referenced
this pull request
Sep 8, 2017
* add initial debug plugin * add debug project in language server product * add copyright, remove startup class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.