Delegate sub-agent enablement to language server by jdneo · Pull Request #349 · microsoft/copilot-for-eclipse · GitHub
Skip to content

Delegate sub-agent enablement to language server - #349

Merged
Sheng Chen (jdneo) merged 2 commits into
mainfrom
server-governed-sub-agent-enablement
Jul 14, 2026
Merged

Delegate sub-agent enablement to language server#349
Sheng Chen (jdneo) merged 2 commits into
mainfrom
server-governed-sub-agent-enablement

Conversation

@jdneo

@jdneo Sheng Chen (jdneo) commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

resolve #304

@jdneo
Delegate sub-agent enablement to language server
f9f33c9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 14, 2026 04:58
Copilot AI reviewed Jul 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR delegates sub-agent enablement entirely to the Copilot language server by removing Eclipse-side gating (preferences/policy DTO/event plumbing) and always advertising the subAgent capability during LSP initialization, aligning the client with server-authoritative policy enforcement.

Changes:

  • Add an ADR documenting why sub-agent enablement is server-governed and remove overlapping client-side mechanisms.
  • Remove the sub-agent toggle and related UI preference plumbing, messages, and constants.
  • Stop deserializing/propagating sub-agent policy in policy/didChange, and always advertise sub-agent capability at init.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/adr/0001-sub-agent-enablement-is-server-governed.md Adds an ADR capturing the rationale/decision to make sub-agent enablement server-authoritative.
CONTEXT.md Introduces glossary terms clarifying “sub-agent”, “sub-agent policy”, and capability semantics.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/messages.properties Removes UI strings for the sub-agent preference toggle.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/Messages.java Removes the corresponding NLS fields for deleted sub-agent preference strings.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/CopilotPreferenceInitializer.java Drops the default value initialization for the removed sub-agent preference key.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/ChatPreferencesPage.java Removes the sub-agent toggle UI and related preference-driven tool configuration updates.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/policy/DidChangePolicyParams.java Removes the sub-agent policy field and updates equals/hashCode/toString accordingly.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/LsStreamConnectionProvider.java Always advertises subAgent capability as enabled during initialization.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageClient.java Stops reacting to sub-agent policy changes from policy/didChange.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/FeatureFlags.java Removes sub-agent policy state and preference-bridging logic.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/events/CopilotEventConstants.java Removes the sub-agent policy change event topic constant.
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/Constants.java Removes the SUB_AGENT_ENABLED preference key constant.

Comment thread docs/adr/0001-sub-agent-enablement-is-server-governed.md Outdated
@jdneo
Potential fix for pull request finding
6530eda 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ethanyhou
Ethan Hou (ethanyhou) approved these changes Jul 14, 2026
View reviewed changes

@ethanyhou Ethan Hou (ethanyhou) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo
Sheng Chen (jdneo) merged commit a10d2a3 into main Jul 14, 2026
3 of 4 checks passed
@jdneo
Sheng Chen (jdneo) deleted the server-governed-sub-agent-enablement branch July 14, 2026 06:30
@ethanyhou Ethan Hou (ethanyhou) mentioned this pull request Aug 7, 2026
Open
@amvalente Antonio Valente (amvalente) mentioned this pull request Sep 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ethanyhou Ethan Hou (ethanyhou) ethanyhou approved these changes
@xinyi-gong xinyi-gong Awaiting requested review from xinyi-gong xinyi-gong is a code owner
@duzitong Zidong Lu (duzitong) Awaiting requested review from duzitong

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Always enabling sub agent

3 participants

@jdneo @ethanyhou