{{ message }}
Repository navigation
fix - stale code block height during incremental chat layout - #343
Merged
Merged
Conversation
xinyi-gong
requested review from
Zidong Lu (duzitong),
Ethan Hou (ethanyhou) and
Sheng Chen (jdneo)
as code owners
July 8, 2026 09:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves chat code-block layout stability by ensuring SourceViewerComposite reports an up-to-date height synchronously (via computeSize(...)), reducing the chance that incremental chat layout caches stale code-block heights while async setBounds(...) is pending.
Changes:
- Override
computeSize(...)inSourceViewerCompositeto measure height directly from the currentStyledTextcontent. - Factor out a shared
getSourceViewerHeight(...)helper and reuse it inrefreshScrollerLayout()for consistent scrollbar-height handling.
Member
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeSize(...)override forSourceViewerCompositeso code block height is measured synchronously from the currentStyledTextcontent.setBounds(...).