{{ message }}
Repository navigation
feat - support edit/create local files outside of workspace - #248
Merged
Merged
Conversation
xinyi-gong
marked this pull request as ready for review
May 22, 2026 01:55
xinyi-gong
requested review from
Zidong Lu (duzitong),
Ethan Hou (ethanyhou) and
Sheng Chen (jdneo)
as code owners
May 22, 2026 01:55
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for tracking and reviewing create_file / insert_edit_into_file operations targeting absolute local filesystem paths outside the Eclipse workspace, integrating them into the existing “file change summary bar” UX and diff/keep/undo flows.
Changes:
- Introduces a
ChangedFileabstraction so the summary bar can track both workspaceIFileand externalPathtargets. - Extends Create/Edit file tools and the compare-editor plumbing to support local files (including empty-baseline diffs for newly created files).
- Adds/updates unit tests and documents a SWTBot test plan for the user-visible local-file flows.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
Sheng Chen (jdneo)
left a comment
Sheng Chen (jdneo)
left a comment
Member
There was a problem hiding this comment.
One issue: #262. But it is out of the scope of current pr. You can address it in later prs.
27 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_fileandedit_filetool when the target is an absolute local file path outside the Eclipse workspace.IFileresources before falling back to local filesystem paths.