iframe-proxy

xinyi-gong · 2026-05-21T07:10:39Z

Summary

This PR updates the Copilot terminal tool to use shell-aware command execution and marker-based completion across Windows and Linux.

Behavior changes

Switch Windows terminal execution from cmd.exe to powershell.exe
Switch Linux terminal execution from /bin/sh to /bin/bash
Remove POSIX sh shell integration support
Add PowerShell and Bash shell integration scripts that emit Copilot OSC markers for:
- prompt start
- prompt end
- command completion with exit code
Use marker-based command completion instead of relying on prompt-character heuristics when shell integration is available
Keep completion strict by requiring a command-finished marker followed by the next prompt-end marker
Interrupt the previous foreground terminal command with Ctrl+C before starting a new foreground command
Kill the active terminal when the user cancels the chat request
Format multiline commands with bracketed paste markers
Truncate terminal output returned to the model to the last 1000 lines
Resolve terminal working directory from the current file’s project first, then referenced files
Update terminal tool descriptions to match the actual shell

Copilot

Pull request overview

This PR improves the terminal tool implementation used by GitHub Copilot for Eclipse by making command execution more shell-aware (PowerShell/Bash), improving completion detection via OSC markers, and adding safety/quality features like cancellation and output truncation.

Changes:

Switch Windows to powershell.exe and Linux to /bin/bash, adding corresponding shell-integration scripts that emit Copilot OSC prompt/command-finish markers.
Move completion detection to a marker-based approach when integration is available, add Ctrl+C interruption when starting a new foreground command, and cancel running commands when the chat request is cancelled.
Normalize/format command input (including bracketed paste for multiline) and truncate/clean terminal output before returning it to the model.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/RunInTerminalToolAdapter.java	Updates tool descriptions for PowerShell/Bash, passes an initial working directory to terminal execution, and truncates/cleans output returned to the model.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatView.java	Cancels the active terminal command when the user cancels an in-flight chat request.
com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/chat/tools/RunInTerminalToolAdapterTest.java	Tightens an assertion and minor formatting cleanup.
com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/terminal/api/TerminalCommandProcessorTest.java	Adds unit tests for command formatting, marker-based completion, prompt-based completion, and output truncation/cleanup.
com.microsoft.copilot.eclipse.ui.terminal/src/com/microsoft/copilot/eclipse/ui/terminal/RunInTerminalTool.java	Implements working-directory support, marker-based completion, Ctrl+C interruption, and UTF-8 decoding for the modern terminal implementation.
com.microsoft.copilot.eclipse.ui.terminal.tm/src/com/microsoft/copilot/eclipse/ui/terminal/tm/RunInTerminalTool.java	Mirrors the modern terminal behavior updates for the legacy TM terminal implementation.
com.microsoft.copilot.eclipse.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/TerminalCommandProcessor.java	Introduces shared logic for formatting commands, detecting completion, stripping markers/control sequences, and truncating output.
com.microsoft.copilot.eclipse.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/ShellIntegrationScripts.java	Replaces the old sh marker constants with structured OSC marker constants + script path helpers for Bash and PowerShell.
com.microsoft.copilot.eclipse.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/IRunInTerminalTool.java	Extends the terminal SPI to accept an initial working directory and support cancellation of the current foreground command.
com.microsoft.copilot.eclipse.terminal.api/scripts/copilot-sh-integration.sh	Removes POSIX sh integration script.
com.microsoft.copilot.eclipse.terminal.api/scripts/copilot-powershell-integration.ps1	Adds PowerShell integration script emitting Copilot OSC markers.
com.microsoft.copilot.eclipse.terminal.api/scripts/copilot-bash-integration.sh	Adds Bash integration script emitting Copilot OSC markers.

Comments suppressed due to low confidence (2)

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/RunInTerminalToolAdapter.java:84

These text-block description lines exceed the 120-character Checkstyle LineLength limit. Please wrap/split the long sentences in this Linux tool description section to keep each physical line <= 120 chars.

          Command Execution:
          - Use && to chain commands on one line
          - Never create a sub-shell (e.g., bash -c "command") unless explicitly asked
          - Prefer pipelines | for data flow
          - Multi-line commands must be complete and non-interactive. Do not run REPLs, continuation-prompt commands, \
          unmatched quotes or brackets, or commands that wait for stdin. For Python/Node scripts, create a file first,
          then run it

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/RunInTerminalToolAdapter.java:107

These macOS/Unix text-block description lines appear to exceed the 120-character Checkstyle LineLength limit. Please wrap/split the long sentences so Checkstyle passes.

        Command Execution:
        - Use && to chain commands on one line
        - Never create a sub-shell (e.g., bash -c "command") unless explicitly asked
        - Prefer pipelines | for data flow
        - Multi-line commands must be complete and non-interactive. Do not run REPLs, continuation-prompt commands, \
        unmatched quotes or brackets, or commands that wait for stdin. For Python/Node scripts, create a file first,
        then run it

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Sheng Chen (jdneo)

LGTM

Sheng Chen (jdneo) · 2026-05-29T02:37:02Z

xinyi-gong added 3 commits May 21, 2026 14:46

improve terminal command execution across windows and linux

4994a1a

remove test

95f9b0e

recover test file

d36ebf6

xinyi-gong marked this pull request as ready for review May 21, 2026 07:50

xinyi-gong requested review from Zidong Lu (duzitong), Ethan Hou (ethanyhou) and Sheng Chen (jdneo) as code owners May 21, 2026 07:50

Copilot AI review requested due to automatic review settings May 21, 2026 07:50

Copilot started reviewing on behalf of xinyi-gong May 21, 2026 07:53

View session

Copilot AI reviewed May 21, 2026

View reviewed changes

resolve comments

7552464

Sheng Chen (jdneo) reviewed May 22, 2026

View reviewed changes

Comment thread ...lipse.ui.terminal.tm/src/com/microsoft/copilot/eclipse/ui/terminal/tm/RunInTerminalTool.java Outdated

Comment thread ...lot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/RunInTerminalToolAdapter.java

resolve comments

5c28032

Sheng Chen (jdneo) reviewed May 25, 2026

View reviewed changes

Comment thread ...lot.eclipse.ui.terminal/src/com/microsoft/copilot/eclipse/ui/terminal/RunInTerminalTool.java Outdated

Sheng Chen (jdneo) reviewed May 25, 2026

View reviewed changes

Comment thread ...se.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/TerminalCommandProcessor.java Outdated

extract command fields into one state

48801f9

Sheng Chen (jdneo) reviewed May 26, 2026

View reviewed changes

remove all the ctrl+c logic

1cad4eb

Sheng Chen (jdneo) reviewed May 26, 2026

View reviewed changes

Comment thread ...se.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/TerminalCommandProcessor.java Outdated

Comment thread ...se.terminal.api/src/com/microsoft/copilot/eclipse/terminal/api/TerminalCommandProcessor.java Outdated

Sheng Chen (jdneo) requested a review from Copilot May 26, 2026 05:51

Copilot started reviewing on behalf of Sheng Chen (jdneo) May 26, 2026 05:51

View session

Copilot AI reviewed May 26, 2026

View reviewed changes

resolve comments

eba8c0e

Sheng Chen (jdneo) approved these changes May 26, 2026

View reviewed changes

Sheng Chen (jdneo) merged commit d6a6992 into main May 26, 2026
4 checks passed

Sheng Chen (jdneo) deleted the tori/powershell branch May 26, 2026 07:28

Sheng Chen (jdneo) mentioned this pull request May 26, 2026

Terminal commands run in wrong directory #41

Closed

xinyi-gong mentioned this pull request May 26, 2026

Iteration Plan for 2026 May #129

Closed

20 of 23 tasks

Sheng Chen (jdneo) mentioned this pull request Jun 22, 2026

[Endgame] 0.19.0 Endgame #300

Closed

27 tasks done

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

xinyi-gong commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Behavior changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sheng Chen (jdneo) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sheng Chen (jdneo) commented May 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xinyi-gong commented May 21, 2026 •

edited

Loading