{{ message }}
Repository navigation
feat: implement file and text search functionality with glob pattern support - #22
Merged
Merged
Conversation
…urce-tree Co-authored-by: Copilot <copilot@github.com>
…rams, and FindTextInFilesResult to records for improved readability and maintainability Co-authored-by: Copilot <copilot@github.com>
Ethan Hou (ethanyhou)
requested review from
Zidong Lu (duzitong),
Sheng Chen (jdneo) and
xinyi-gong
as code owners
April 23, 2026 09:10
Contributor
There was a problem hiding this comment.
Pull request overview
Implements client-side file and text search APIs to support Copilot language server requests (notably for non-local/virtual URI schemes like semanticfs://) within the Eclipse workspace.
Changes:
- Added
workspace/findFilesandworkspace/findTextInFilesJSON-RPC request handlers in the core language client. - Implemented recursive workspace traversal in
FileUtilsto match files via glob patterns and search file contents via text/regex. - Added new LSP protocol record types for the request parameters and results, plus a new core bundle dependency on
org.eclipse.core.filesystem.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
Co-authored-by: Copilot <copilot@github.com>
xinyi-gong
reviewed
Apr 24, 2026
Co-authored-by: Copilot <copilot@github.com>
Closed
24 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test:
CLS: ethan/supportABAPFileSearch
The file search should be supported in semanticfs:
