{{ message }}
Repository navigation
Fix optional BYOK display name label - #158
Merged
Merged
Conversation
xinyi-gong
requested review from
Zidong Lu (duzitong),
Ethan Hou (ethanyhou) and
Sheng Chen (jdneo)
as code owners
May 9, 2026 01:36
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the BYOK “Add Model” dialog label to correctly indicate that the “Display Name” field is optional, aligning the UI text with the dialog’s validation/behavior.
Changes:
- Removed the required-field marker (
*) from the BYOK “Display Name” label string.
Ethan Hou (ethanyhou)
approved these changes
May 9, 2026
Closed
37 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: