{{ message }}
Repository navigation
feat - update BYOK disable tip - #140
Merged
Merged
Conversation
xinyi-gong
marked this pull request as ready for review
May 7, 2026 04:27
xinyi-gong
requested review from
Zidong Lu (duzitong),
Ethan Hou (ethanyhou) and
Sheng Chen (jdneo)
as code owners
May 7, 2026 04:27
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the BYOK (custom models) disabled-tip text and corresponding message key to align the Eclipse UI messaging with BYOK availability for Business/Enterprise org-managed settings, and records the change in the changelog.
Changes:
- Replaced the BYOK “preview disabled” tip/message key with a new “disabled by enterprise settings” tip.
- Updated Java NLS bindings and UI usage to reference the new message key.
- Added a changelog entry announcing BYOK support for Business/Enterprise users.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Ethan Hou (ethanyhou)
previously approved these changes
May 7, 2026
Sheng Chen (jdneo)
previously approved these changes
May 7, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
xinyi-gong
dismissed stale reviews from Sheng Chen (jdneo) and Ethan Hou (ethanyhou)
via
May 7, 2026 04:58
e9f4581
Sheng Chen (jdneo)
approved these changes
May 7, 2026
Member
|
Andrey Loskutov (@iloveeclipse) BYOK for enterprise and business is unblocked now. |
Contributor
|
Great. Will there be a nightly build to test soon? |
Member
Closed
24 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BYOK now supports Copilot Business and Enterprise users when enabled by their organization (see https://github.com/microsoft/copilot-language-server-internal/pull/733). This PR updates the tip to reflect this change.