iframe-proxy

vigneshwarKV · 2026-07-01T10:44:32Z

Problem

In the web dashboard's for-each group detail panel, each row under ITEMS has a stacked-layers "Dive into subworkflow" control. Clicking it navigates into the iteration's nested workflow — but only when the item is COMPLETED or FAILED. While an item is RUNNING, clicking the icon does nothing.

Root cause

The dive-in control was a <span role="button"> nested inside the row's expand/collapse <button>:

<button onClick={...toggle...} disabled={!hasDetails}>
  ...chevron / key / metrics / status badge...
  {canDiveIn && (
    <span role="button" onClick={(e) => { e.stopPropagation(); navigateIntoSubworkflow(...) }}>
      <Layers />
    </span>
  )}
</button>

The outer toggle is disabled={!hasDetails}, where hasDetails = prompt || output != null || activity?.length || error_type. A running workflow-type iteration hasn't produced any of those yet (its prompt/output/activity live on the child SubworkflowContext, not on the for-each item), so hasDetails is false and the outer button is disabled.

A disabled <button> suppresses click events across its entire subtree, so the nested dive-in span never received the click. Once the item failed (the for_each_item_failed event carries an error_type) or completed, hasDetails flipped to true, the button was enabled, and dive-in worked — exactly matching the "only navigates when FAILED" symptom.

The store's navigateIntoSubworkflow and the SubworkflowContext for the running iteration were both fine (the context exists as soon as subworkflow_started fires, so the icon correctly renders for running items) — the click simply never reached the handler.

Fix

Restructure the header row so the expand/collapse toggle and the dive-in control are siblings inside a plain flex <div>, instead of nesting an interactive element inside a (sometimes disabled) button. The dive-in is now a real <button>, so it:

stays clickable regardless of the toggle's disabled state,
gets native keyboard/focus behavior (dropping the manual role/tabIndex/onKeyDown/stopPropagation shim), and
no longer produces invalid nested-interactive-element markup.

Only GroupDetail.tsx changed behaviorally; the static/ bundle is the rebuilt frontend (make build-frontend).

Verification

Reproduced against a real for-each fan-out (two concurrent workflow-type iterations): before the change, the dive-in icon was inert on the RUNNING row and worked on the FAILED row; after the change it navigates into the nested workflow in both states. tsc -b (via make build-frontend) passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

vigneshwarKV · 2026-07-01T10:58:37Z

@vigneshwarKV please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.

Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.

Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.

Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Keyvalue"

The per-item "Dive into subworkflow" control in the for-each group detail panel was a `<span role="button">` nested inside the row's expand/collapse `<button>`. That outer button is `disabled` whenever the item has no expandable details (`hasDetails` false) — the case for a running workflow-type iteration that has not yet produced a prompt/output/activity/ error. A disabled `<button>` suppresses click events across its entire subtree, so the nested dive-in never fired while the item was RUNNING. Once the item FAILED (carrying an `error_type`) or COMPLETED, `hasDetails` became true, the button was enabled, and dive-in worked — matching the reported "only navigates when FAILED" behavior. Restructure the header row so the expand/collapse toggle and the dive-in control are siblings inside a plain flex `<div>` rather than nesting an interactive element inside a (sometimes disabled) button. The dive-in is now a real `<button>`, so it stays clickable regardless of the toggle's disabled state and no longer relies on `stopPropagation`/manual keydown handling. This also removes the invalid nested-interactive-element markup. Rebuilds the bundled dashboard (`make build-frontend`); the static/ changes are the regenerated Vite bundle (content-hashed filenames) with index.html pointing at the new hashes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

codecov-commenter · 2026-07-01T12:50:30Z

jrob5756

Approving. Validated the root cause and fix end-to-end, plus a multi-agent review (code quality, tests, comments, dead code, simplification): the dive-in is correctly un-nested from the disabled toggle so it stays clickable for running for-each items. Improves a11y (native button), removes invalid nested-interactive markup and the manual keydown/stopPropagation shim, passes tsc -b, and the rebuilt bundle is byte-identical. Only optional nits remain (aria-label, type="button" on the toggle, a frontend test-harness follow-up).

vigneshwarKV pushed a commit to vigneshwarKV/conductor that referenced this pull request Jul 1, 2026

docs(changelog): note for-each dive-in fix (microsoft#273)

a1ee1cf

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Vignesh and others added 2 commits July 1, 2026 16:35

docs(changelog): note for-each dive-in fix (microsoft#273)

6e03d33

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

vigneshwarKV force-pushed the fix/foreach-running-item-dive-in branch from a1ee1cf to 6e03d33 Compare July 1, 2026 11:06

jrob5756 approved these changes Jul 1, 2026

View reviewed changes

jrob5756 merged commit 6418466 into microsoft:main Jul 1, 2026
9 checks passed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(web): keep for-each dive-in clickable for running items#273

fix(web): keep for-each dive-in clickable for running items#273
jrob5756 merged 2 commits into
microsoft:mainfrom
vigneshwarKV:fix/foreach-running-item-dive-in

vigneshwarKV commented Jul 1, 2026 •

edited

Loading

Uh oh!

vigneshwarKV commented Jul 1, 2026

Contribution License Agreement

Uh oh!

codecov-commenter commented Jul 1, 2026

Uh oh!

jrob5756 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

vigneshwarKV commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root cause

Fix

Verification

Uh oh!

vigneshwarKV commented Jul 1, 2026

Contribution License Agreement

Uh oh!

codecov-commenter commented Jul 1, 2026

Codecov Report

Uh oh!

jrob5756 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vigneshwarKV commented Jul 1, 2026 •

edited

Loading