OAuthPrompt was constructing InvokeResponse incorrectly in some cases. by tracyboehrer · Pull Request #1798 · microsoft/botbuilder-python · GitHub
Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

OAuthPrompt was constructing InvokeResponse incorrectly in some cases.#1798

Merged
axelsrz merged 3 commits into
mainfrom
tracyboehrer/oauth_prompt_invokeresponse
Nov 3, 2021
Merged

OAuthPrompt was constructing InvokeResponse incorrectly in some cases.#1798
axelsrz merged 3 commits into
mainfrom
tracyboehrer/oauth_prompt_invokeresponse

Conversation

@tracyboehrer

Copy link
Copy Markdown
Member

Fixes #1797

@axelsrz axelsrz merged commit 7d7fa53 into main Nov 3, 2021
@axelsrz axelsrz deleted the tracyboehrer/oauth_prompt_invokeresponse branch November 3, 2021 16:53
@maheshpardeshi

Copy link
Copy Markdown

@Wajeed-msft

Copy link
Copy Markdown

@axelsrz , @tracyboehrer - Could you please share the SDK version from which this change is avaialble?

@tracyboehrer

Copy link
Copy Markdown
Member Author

@maheshpardeshi and @Wajeed-msft, We will release a 4.14.1 patch shortly.

@maheshpardeshi

maheshpardeshi commented Dec 29, 2021

Copy link
Copy Markdown

Hello Team, till when 4.14.1 will get released. We are waiting for this and our solution is not working on the production.

tracyboehrer added a commit that referenced this pull request Jan 4, 2022
* OAuthPrompt was constructing InvokeResponse incorrectly in some cases. (#1798)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

* Bump to 4.14.1

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
tracyboehrer added a commit that referenced this pull request Jan 4, 2022
#1798) (#1845)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
tracyboehrer added a commit that referenced this pull request Jan 4, 2022
* OAuthPrompt was constructing InvokeResponse incorrectly in some cases. (#1798)

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>

* Delete app ids, pws. (#1802)

* Delete app ids, pws.

* Comment out broken tests.

* Comment out the final failing test.

* Formatted for Black compliance

* lint fixes

* Another black-compliance fix.

Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
Co-authored-by: BruceHaley <v-brucehaley@microsoft.com>
@tracyboehrer

Copy link
Copy Markdown
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In bot builder dialog after successful login, login_step function is not getting called.

4 participants