[SDK][Bot-Azure] Add CosmosDbPartitionedStorage component by VictorGrycuk · Pull Request #1024 · microsoft/botbuilder-java · GitHub
Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

[SDK][Bot-Azure] Add CosmosDbPartitionedStorage component#1024

Merged
tracyboehrer merged 7 commits into
microsoft:mainfrom
southworks:internal/southworks/CosmosDBPartitionedStorage/base
Feb 26, 2021
Merged

[SDK][Bot-Azure] Add CosmosDbPartitionedStorage component#1024
tracyboehrer merged 7 commits into
microsoft:mainfrom
southworks:internal/southworks/CosmosDBPartitionedStorage/base

Conversation

@VictorGrycuk

Copy link
Copy Markdown
Contributor

Fixes #739

Description

Implements support for CosmosDbPartitionedStorage class and its tests.

Specific Changes

Adds the following classes:

  • CosmosDbPartitionedStorage
  • CosmosDbPartitionedStorageOptions
  • CosmosDbKeyEscape
  • Updates the pom.xml file with the necessary dependencies
  • Adds the necessary tests for the CosmosDbPartitionedStorage and CosmosDbKeyEscape classes

Testing

Unit tests of bot-azure passing correctly
image

mvn clean install passing correctly
image

@VictorGrycuk VictorGrycuk marked this pull request as ready for review February 26, 2021 18:16
@VictorGrycuk

Copy link
Copy Markdown
Contributor Author

@VictorGrycuk

Copy link
Copy Markdown
Contributor Author

@tracyboehrer we removed the following files as they are generated during the build:

  • DocumentDB.Spatial.Sql.dll
  • Microsoft.Azure.Documents.ServiceInterop.dll

We noticed that the .gitignore is missing a configuration for these files. Do you want us to add an entry in the configuration to ignore these binaries?

@tracyboehrer

tracyboehrer commented Feb 26, 2021

Copy link
Copy Markdown
Member

@VictorGrycuk So these unit tests require the cosmosdb emulator and that appears to be why the PR build is failing. I need to look into how DotNet is dealing with this.

@tracyboehrer tracyboehrer reopened this Feb 26, 2021
@tracyboehrer tracyboehrer reopened this Feb 26, 2021
@tracyboehrer tracyboehrer merged commit 5066b57 into microsoft:main Feb 26, 2021
@tracyboehrer

Copy link
Copy Markdown
Member

@Batta32 Batta32 deleted the internal/southworks/CosmosDBPartitionedStorage/base branch March 1, 2021 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bot-azure, CosmosDBPartitionedStorage

3 participants