{{ message }}
Fix pyright errors from weave ≥0.52.27 interface changes#497
Draft
Fix pyright errors from weave ≥0.52.27 interface changes#497
Conversation
Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
…nd add missing abstract method stubs Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Pyright lint errors in weave.py
Fix pyright errors from weave ≥0.52.27 interface changes
Feb 28, 2026
ultmaster
reviewed
Feb 28, 2026
Contributor
There was a problem hiding this comment.
@copilot No need to bump weave required version. to test, you need to use uv lock --upgrade to test latest version.
Contributor
Author
There was a problem hiding this comment.
Reverted the weave version bump in f487e48. pyproject.toml and uv.lock are now unchanged. Added a TYPE_CHECKING guard for backward compat with the OTelExportReq/OTelExportRes rename so the code works at runtime with weave>=0.52.22.
Contributor
|
@copilot No need to bump weave required version. to test, you need to use uv lock --upgrade to test latest version. |
Co-authored-by: ultmaster <8463288+ultmaster@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weave renamed
OtelExportReq/OtelExportRes→OTelExportReq/OTelExportResin v0.52.27 and added new abstract methods toTraceServerInterface/ObjectInterfacein v0.52.29, causing 10 pyright errors.otel_exportsignature and body to useOTelExportReq/OTelExportResTYPE_CHECKINGguarded shim that aliases old names to new names at runtime for weave < 0.52.27, keepingweave>=0.52.22unchanged inpyproject.tomlannotation_queue_delete,annotation_queue_update(raiseNotImplementedError) andeval_results_query(returns empty results) toInMemoryWeaveTraceServerOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.