Update lib.dom.d.ts: `MutationObserverInit.attributeFilter` can accept an iterator by trusktr · Pull Request #55989 · microsoft/TypeScript · GitHub
Skip to content

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator#55989

Open
trusktr wants to merge 1 commit intomicrosoft:mainfrom
trusktr:patch-2
Open

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator#55989
trusktr wants to merge 1 commit intomicrosoft:mainfrom
trusktr:patch-2

Conversation

@trusktr
Copy link
Copy Markdown
Contributor

@trusktr trusktr commented Oct 5, 2023 •
edited
Loading

Re-opening of #50031. Please see description there.

Please point me to guidance on how to make this change, and I'll update the PR.

Closes #55990

@trusktr
Update lib.dom.d.ts
f38d94d 
`MutationObserverInit.attributeFilter` can accept an iterator
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 5, 2023
@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Oct 5, 2023

@trusktr trusktr mentioned this pull request Oct 5, 2023
Open
@fatcerberus
Copy link
Copy Markdown

fatcerberus commented Oct 5, 2023

The bot pointed you to the relevant documentation in #50031 but basically you have to make changes to the DOM libs at https://github.com/Microsoft/TSJS-lib-generator, because the ones in the TS repo are autogenerated from there.

@jakebailey
Copy link
Copy Markdown
Member

jakebailey commented Oct 5, 2023

The bot pointed you to the relevant documentation in #50031 but basically you have to make changes to the DOM libs at Microsoft/TSJS-lib-generator, because the ones in the TS repo are autogenerated from there.

That time, they had edited lib, which used to hold a checked-in compiler for self compilation and no longer exists (hence why this hasn't been auto-closed yet). So this PR is "fine" contribution wise. Of course, the PR has syntax error and I'm not convinced it's correct, either.

@fatcerberus
Copy link
Copy Markdown

fatcerberus commented Oct 5, 2023

Hmm, so is TSJS-lib-generator obsolete now?

@jakebailey
Copy link
Copy Markdown
Member

jakebailey commented Oct 5, 2023

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 2, 2023
@RyanCavanaugh RyanCavanaugh added this to the Post-7.0 lib candidates milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

@navya9singh navya9singh Awaiting requested review from navya9singh

At least 1 approving review is required to merge this pull request.

Assignees

@navya9singh navya9singh

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Status: Waiting on reviewers

Milestone

Post-7.0 lib candidates

Development

Successfully merging this pull request may close these issues.

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator

7 participants

@trusktr @typescript-bot @fatcerberus @jakebailey @sandersn @RyanCavanaugh @navya9singh