Revert changes for template literal types, keeping tests. by DanielRosenwasser · Pull Request #42588 · microsoft/TypeScript · GitHub
Skip to content

Revert changes for template literal types, keeping tests.#42588

Merged
DanielRosenwasser merged 2 commits intomasterfrom
undoTemplateLiteralTypes
Feb 3, 2021
Merged

Revert changes for template literal types, keeping tests.#42588
DanielRosenwasser merged 2 commits intomasterfrom
undoTemplateLiteralTypes

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser commented Feb 1, 2021

We have reservations about inferring template string types by default, so this PR applies the revert for work discussed at #42589.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 1, 2021
@DanielRosenwasser DanielRosenwasser marked this pull request as ready for review February 1, 2021 23:00
@typescript-bot
Copy link
Copy Markdown
Collaborator

@DanielRosenwasser
Copy link
Copy Markdown
Member Author

Will probably merge in an hour or two

@DanielRosenwasser DanielRosenwasser merged commit cce4bfb into master Feb 3, 2021
@jcalz
Copy link
Copy Markdown
Contributor

jcalz commented Feb 8, 2021

So #42588 undoes #41891, right? Just cross-linking them.

@pedrodurek
Copy link
Copy Markdown

I hope you can bring it back at some point 🙏

@DanielRosenwasser DanielRosenwasser deleted the undoTemplateLiteralTypes branch February 12, 2021 18:00
@DanielRosenwasser
Copy link
Copy Markdown
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants