{{ message }}
Implement LWG-4293: span::subspan/first/last chooses wrong constructor when T is const-qualified bool - #6437
Open
zika (tycket033-tech) wants to merge 2 commits into
Conversation
… when T is const-qualified bool
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation consistently applies LWG-4293 across every affected overload with matching test coverage.
Pull request overview
Aligns std::span subview construction with LWG-4293.
Changes:
- Direct-initializes spans returned by
first,last, andsubspan. - Adds constexpr/runtime coverage for
span<const bool>subviews.
File summaries
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6239
LWG-4293 changes the Effects of
span::first/last/subspantodirect-initialize the returned span (
(ptr, count)) instead of brace-initializing,so an
initializer_listconstructor can never hijack these calls.Since P2447R6 was reverted and MSVC STL never implemented it anyway, this has
zero functional impact — just a wording-sync per "Do What The Standard Says".