`<regex>`: Clean up fullmatch flag handling by muellerj2 · Pull Request #6261 · microsoft/STL · GitHub
Skip to content

<regex>: Clean up fullmatch flag handling#6261

Merged
StephanTLavavej merged 2 commits into
microsoft:mainfrom
muellerj2:regex-cleanup-fullmatch-flag
Apr 29, 2026
Merged

<regex>: Clean up fullmatch flag handling#6261
StephanTLavavej merged 2 commits into
microsoft:mainfrom
muellerj2:regex-cleanup-fullmatch-flag

Conversation

@muellerj2

@muellerj2 muellerj2 commented Apr 18, 2026

Copy link
Copy Markdown

This PR performs some minor cleanups:

  • _Regex_match1() took a flag _Full, but all call sites pass true, so we can just remove this argument. (I renamed the function even though it's not necessary, strictly speaking; there will be more changes to its signature.)
  • _Matcher3::_Match took an argument _Full_match, but the value is the same for all calls on the same instance. Let's move this argument to the constructor and remove it from _Match2() (rename also not strictly necessary).
  • Drive-by change: Add more const to updated function definitions.
  • Drive-by change: The call sites affected by the other changes are updated to make _STD-qualified calls.

@muellerj2 muellerj2 requested a review from a team as a code owner April 18, 2026 18:18
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Apr 18, 2026
@StephanTLavavej StephanTLavavej added enhancement Something can be improved regex meow is a substring of homeowner labels Apr 18, 2026
Comment thread stl/inc/regex Outdated
Comment thread stl/inc/regex Outdated
Comment thread stl/inc/regex Outdated
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Apr 18, 2026
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 28, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej merged commit 465d661 into microsoft:main Apr 29, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Apr 29, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved regex meow is a substring of homeowner

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants