Avoid runtime sign dispatch in vectorized `minmax_element` by hazzlim · Pull Request #6194 · microsoft/STL · GitHub
Skip to content

Avoid runtime sign dispatch in vectorized minmax_element#6194

Merged
StephanTLavavej merged 2 commits into
microsoft:mainfrom
hazzlim:minmax_element-unsigned
Mar 31, 2026
Merged

Avoid runtime sign dispatch in vectorized minmax_element#6194
StephanTLavavej merged 2 commits into
microsoft:mainfrom
hazzlim:minmax_element-unsigned

Conversation

@hazzlim

@hazzlim hazzlim commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Fixes #6176

I'm not sure about the naming of __std_{min,max,minmax}_element_{f,d}_no_unused - if anyone has any better suggestions!

@hazzlim hazzlim requested a review from a team as a code owner March 31, 2026 00:01
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Mar 31, 2026
@StephanTLavavej StephanTLavavej self-assigned this Mar 31, 2026
@StephanTLavavej StephanTLavavej added performance Must go faster ARM64 Related to the ARM64 architecture ARM64EC I can't believe it's not x64! labels Mar 31, 2026
@AlexGuteniev

Copy link
Copy Markdown
Contributor

@StephanTLavavej StephanTLavavej removed their assignment Mar 31, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 31, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 31, 2026
@StephanTLavavej StephanTLavavej merged commit 2c25edf into microsoft:main Mar 31, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Mar 31, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARM64EC I can't believe it's not x64! ARM64 Related to the ARM64 architecture performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Vectorized minmax_element: avoid runtime sign dispatch

3 participants