`<xutility>`: Fix incorrect `noexcept` specification of `_Debug_lt_pred` by NylteJ · Pull Request #5931 · microsoft/STL · GitHub
Skip to content

<xutility>: Fix incorrect noexcept specification of _Debug_lt_pred#5931

Merged
StephanTLavavej merged 2 commits into
microsoft:mainfrom
NylteJ:debug_lt_pred
Dec 8, 2025
Merged

<xutility>: Fix incorrect noexcept specification of _Debug_lt_pred#5931
StephanTLavavej merged 2 commits into
microsoft:mainfrom
NylteJ:debug_lt_pred

Conversation

@NylteJ

@NylteJ NylteJ commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

The current noexcept specification of _Debug_lt_pred does not account for predicates whose return type is not bool. If converting the result to bool throws, the program will terminate immediately.

@NylteJ NylteJ requested a review from a team as a code owner December 2, 2025 15:48
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Dec 2, 2025
Comment thread stl/inc/xutility Outdated
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Dec 4, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Dec 6, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Dec 7, 2025
@StephanTLavavej StephanTLavavej merged commit f1a6402 into microsoft:main Dec 8, 2025
45 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Dec 8, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

@NylteJ NylteJ deleted the debug_lt_pred branch December 9, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants