Build the benchmark with clang-cl only on x64 by AlexGuteniev · Pull Request #5704 · microsoft/STL · GitHub
Skip to content

Build the benchmark with clang-cl only on x64#5704

Merged
StephanTLavavej merged 3 commits into
microsoft:mainfrom
AlexGuteniev:randomly-fix-random-build-issue
Sep 10, 2025
Merged

Build the benchmark with clang-cl only on x64#5704
StephanTLavavej merged 3 commits into
microsoft:mainfrom
AlexGuteniev:randomly-fix-random-build-issue

Conversation

@AlexGuteniev

Copy link
Copy Markdown
Contributor

There's infrequent but not very rara access violation when linking with the benchmark using clang-cl on x86.

Apparently x64 works always.

Let's keep only x64 built on CI. It might worth giving another try when clang-cl is updated to the next major.

Note that this change does not prevent building x86 benchmark with clang-cl locally, only makes it possible for this configuration to bit rot.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 29, 2025 19:27
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Aug 29, 2025
@StephanTLavavej StephanTLavavej added performance Must go faster test Related to test code labels Aug 29, 2025
Comment thread azure-devops/build-benchmarks.yml Outdated
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Aug 29, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Sep 10, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej merged commit b2976dc into microsoft:main Sep 10, 2025
39 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Sep 10, 2025
@StephanTLavavej

Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej added infrastructure Related to repository automation and removed performance Must go faster test Related to test code labels Sep 10, 2025
@AlexGuteniev AlexGuteniev deleted the randomly-fix-random-build-issue branch September 10, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Related to repository automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants