{{ message }}
[WIP] Transition away from OS-33790456#5660
Closed
davidmrdavid wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@DanielaE - thanks for reaching out. Yeah you're right, and the good news is that we have applied this change more than just the "time functions". Below is the full list: Unfortunately, the following 3 functions had to be scoped out due to additional blockers:
So I think most of the functions you list, minus |
|
Cool 😎 - thanks a lot for your efforts. I' looking forward to the upcoming UCRT and hope the updated functions will pass all my tests just as fine as they do with my current workaround. |
Member
Author
github-project-automation
Bot
moved this from Initial Review
to Done
in STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
As reported in devcomm 1126857, several UCRT functions are declare as
static inline, especially those intime.h.This is a non-conforming signature, and prevents us from naively exporting those functions through modules. We have workarounds for this, but they're imperfect.
Thankfully - we just merged code in the UCRT that should improve this.
Soon, the UCRT will expose a binary macro,
_STATIC_INLINE_UCRT_FUNCTIONSto control these signatures. When set to0, these functions will have external linkage (conforming behavior) and when set to1they will continue to have static linkage (i.e. this is the escape hatch for backwards compatibility).This PR:
Consumes this macro so that we can expose these
time-related CRT functions via modules when the UCRT allows it. In short - we disable the workaround for exportingctimefunctions via modules by inspecting the value of_STATIC_INLINE_UCRT_FUNCTIONSStill pending: