{{ message }}
Make benchmarks compiling in clang-cl#5533
Merged
Merged
Conversation
frederick-vs-ja
left a comment
frederick-vs-ja
left a comment
Contributor
There was a problem hiding this comment.
But I wonder why changes elsewhere are relevant.
AlexGuteniev
commented
May 23, 2025
Contributor
Author
There was a problem hiding this comment.
@frederick-vs-ja the rest are just const that can potentially be optimized, so DoNotOptimize is deprecated
StephanTLavavej
approved these changes
May 29, 2025
Member
Closed
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #5479
Most of the time it is warning about deprecated
benchmark::DoNotOptimizefor constants.🏗️ Build steps
Build STL as usual:
Then add
-DCMAKE_CXX_COMPILER=clang-clto benchmark build: