{{ message }}
<numbers>: Rework the implementation when concepts are missing#3633
Merged
StephanTLavavej merged 7 commits intoApr 14, 2023
Merged
Conversation
strega-nil-ms
suggested changes
Apr 7, 2023
strega-nil-ms
left a comment
strega-nil-ms
left a comment
Contributor
There was a problem hiding this comment.
Minor change, but otherwise this looks great :)
Rename `_Reject_primary_template(_t)` to `_Reject_invalid(_t)`. Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
StephanTLavavej
approved these changes
Apr 8, 2023
Member
strega-nil-ms
approved these changes
Apr 11, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In recent PR #3623 I noticed that the implementation of
<numbers>when concepts are unavailable didn't seem correct enough. These variable templates are required to support possibly cv-qualified floating-point types due tostd::floating_point, but the current concept-free implementation only supports cv-unqualified FP types.This PR is adding test coverage for cv-qualified FP types, and rewriting the concept-free implementation. Technically, only the primary template is used, but I believe that the difference from the standard wording is unobservable.
Warning C4197 was encountered during local test. I think it's OK to only suppress that warning in testing, because it's already weird to use something that is both
constexprandvolatile.