Move `_Char_traits_eq` and `_Char_traits_lt` from `<xstring>` to `<regex>` by frederick-vs-ja · Pull Request #3625 · microsoft/STL · GitHub
Skip to content

Move _Char_traits_eq and _Char_traits_lt from <xstring> to <regex>#3625

Merged
StephanTLavavej merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:throughput-regex-xstring
Apr 7, 2023
Merged

Move _Char_traits_eq and _Char_traits_lt from <xstring> to <regex>#3625
StephanTLavavej merged 1 commit into
microsoft:mainfrom
frederick-vs-ja:throughput-regex-xstring

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

As these functors are only used in <regex>. Separated from #3623.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner April 5, 2023 06:49
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 5, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

@barcharcraz

Copy link
Copy Markdown
Contributor

Verified identical code (only movement). Looks good.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2df667e into microsoft:main Apr 7, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

@frederick-vs-ja frederick-vs-ja deleted the throughput-regex-xstring branch April 8, 2023 05:18
@StephanTLavavej StephanTLavavej added the regex meow is a substring of homeowner label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regex meow is a substring of homeowner throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants