{{ message }}
Implement LWG-3869 Deprecate std::errc constants related to UNIX STREAMS#3487
Merged
Conversation
CaseyCarter
approved these changes
Feb 21, 2023
Contributor
strega-nil-ms
approved these changes
Feb 21, 2023
StephanTLavavej
approved these changes
Feb 22, 2023
Member
|
Thanks! FYI @CaseyCarter @strega-nil-ms , I pushed 3 commits: Oxford comma, fix message to mention the correct SILENCE macro, and rename the macros to talk about UNIX_STREAMS plural. Please meow if you have concerns. |
CaseyCarter
approved these changes
Feb 22, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #3420.
It seems meaningful to apply the deprecation to older modes, since the changes in the upstream standards (original version of POSIX 2008) predated C++11.