{{ message }}
Uncomment resolutions of applied LWG issues#3461
Merged
Merged
Conversation
a7633f9 to
02e547b
Compare
Covers: * LWG-3085 * LWG-3664 * LWG-3723 * LWG-3742 * LWG-3807 * LWG-3857 * LWG-3867 I've verified that we completely implement the resolutions of these issues. Drive-by: remove extraneous `()` in the constraints on `basic_string_view`'s range constructor.
02e547b to
e068a97
Compare
61 tasks
StephanTLavavej
approved these changes
Feb 13, 2023
strega-nil-ms
suggested changes
Feb 13, 2023
strega-nil-ms
left a comment
Contributor
There was a problem hiding this comment.
This is missing changes in:
tests/libcxx/expected_results.txt:623tests/libcxx/skipped_tests.txt:623tests/std/tests/P0220R1_string_view/test.cpp:376
diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt
index dcb235da..bf43ff99 100644
--- a/tests/libcxx/expected_results.txt
+++ b/tests/libcxx/expected_results.txt
@@ -620,7 +620,7 @@ std/language.support/support.limits/support.limits.general/format.version.compil
# libc++ doesn't yet implement LWG-3670
std/ranges/range.factories/range.iota.view/iterator/member_typedefs.compile.pass.cpp FAIL
-# libc++ doesn't speculatively implement LWG-3857
+# libc++ doesn't yet implement LWG-3857
std/strings/string.view/string.view.cons/from_range.pass.cpp FAIL
std/strings/string.view/string.view.cons/from_string1.compile.fail.cpp FAIL
std/strings/string.view/string.view.cons/from_string2.compile.fail.cpp FAIL
diff --git a/tests/libcxx/skipped_tests.txt b/tests/libcxx/skipped_tests.txt
index 6f494826..95e3cc63 100644
--- a/tests/libcxx/skipped_tests.txt
+++ b/tests/libcxx/skipped_tests.txt
@@ -620,7 +620,7 @@ language.support\support.limits\support.limits.general\format.version.compile.pa
# libc++ doesn't yet implement LWG-3670
ranges\range.factories\range.iota.view\iterator\member_typedefs.compile.pass.cpp
-# libc++ doesn't speculatively implement LWG-3857
+# libc++ doesn't yet implement LWG-3857
strings\string.view\string.view.cons\from_range.pass.cpp
strings\string.view\string.view.cons\from_string1.compile.fail.cpp
strings\string.view\string.view.cons\from_string2.compile.fail.cpp
diff --git a/tests/std/tests/P0220R1_string_view/test.cpp b/tests/std/tests/P0220R1_string_view/test.cpp
index 78324c1c..0484c73d 100644
--- a/tests/std/tests/P0220R1_string_view/test.cpp
+++ b/tests/std/tests/P0220R1_string_view/test.cpp
@@ -373,7 +373,6 @@ constexpr bool test_case_range_constructor() {
static_assert(!is_convertible_v<string_view, basic_string_view<char, constexpr_char_traits>>);
static_assert(!is_convertible_v<basic_string_view<char, constexpr_char_traits>, string>);
- // LWG-3857 basic_string_view should allow explicit conversion when only traits vary
static_assert(is_constructible_v<string_view, basic_string<char, constexpr_char_traits>>);
static_assert(is_constructible_v<basic_string_view<char, constexpr_char_traits>, string_view>);
Contributor
Author
Member
|
I am neutral on the |
StephanTLavavej
approved these changes
Feb 13, 2023
strega-nil-ms
approved these changes
Feb 13, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Covers:
I've verified that we completely implement the resolutions of these issues.
Drive-by: remove extraneous
()in the constraints onbasic_string_view's range constructor.