{{ message }}
LWG-3810: CTAD for basic_format_args#3421
Merged
Merged
Conversation
61 tasks
StephanTLavavej
approved these changes
Feb 12, 2023
Comment on lines
+1994
to
+1995
Member
There was a problem hiding this comment.
No change requested, note to other reviewers: Deduction guides can't be exported for modules, they're just automatically available if the class is exported (which is the case here), so the lack of any _EXPORT_STD is normal.
CaseyCarter
approved these changes
Feb 13, 2023
Co-authored-by: Casey Carter <Casey@Carter.net>
StephanTLavavej
approved these changes
Feb 13, 2023
Member
|
I've pushed a commit to address @CaseyCarter's suggestion (using braces for the temporary, and applying |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3414.