{{ message }}
P2278R4: views::as_const#3234
Merged
Merged
Conversation
Member
JMazurkiewicz
force-pushed
the
as_const_view
branch
from
ad05214 to
9a9d7a3
Compare
Contributor
Author
|
And... it's an ICE 😤 |
Contributor
|
Do you happen to have a reduced case for this ICE? If not don't worry about it, I'll reduce it and push a transition comment. |
Contributor
Author
Nope |
Contributor
|
Filed the frontend bug internally as VSO-1692469. I have not pushed a transition comment as I think the workaround improves the code anyway, so I don't think we need to come back to it when this bug is fixed. |
barcharcraz
approved these changes
Dec 7, 2022
StephanTLavavej
approved these changes
Dec 10, 2022
Member
|
Thanks, this looks fantastic! 😻 I pushed changes for 3 incredibly tiny nitpicks in the test code. |
CaseyCarter
approved these changes
Dec 15, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2918 - "
cbeginshould always return a constant iterator".