{{ message }}
Cleanup headers - #1270
Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits intoSep 26, 2020
Merged
Conversation
SunnyWar
marked this pull request as ready for review
September 5, 2020 06:39
Stephan T. Lavavej (StephanTLavavej)
requested changes
Sep 23, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks! After checking each of these changes, you have a lot of great finds of unused headers here. I commented every occurrence that I think needs to be restored/adjusted (in addition to the ones that Casey Carter (@CaseyCarter) noted); I think after one more revision this will be ready to merge. 😺
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 24, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good! I pushed a one-line change to adjust the spacing before a comment in a clang-format-off block (we conventionally use one space before comments). This will also cycle the tests which timed out for an unknown infrastructure reason (I saw that affect another PR too).
Casey Carter (CaseyCarter)
approved these changes
Sep 24, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.