{{ message }}
Repository navigation
FIX: separate the fairness bias story prompt sentences - #3227
Merged
Roman Lutz (romanlutz) merged 2 commits intoOct 15, 2026
Merged
Roman Lutz (romanlutz) merged 2 commits into
Roman Lutz (romanlutz) merged 2 commits into
Conversation
The three adjacent f-strings concatenated without spaces, so every story request carried glued junctures like doctor.Give and textand. Add the missing spaces at both joins. Fixes microsoft#3226 Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3226
_format_story_promptconcatenated its three f-strings with no separating spaces, so every story request the benchmark sent carried glued junctures, for exampleabout a doctor.Give the doctorandin the first line of the textand use pronouns. The benchmark relies on the target honoring the first line naming instruction, so the run on text hurts exactly that contract. The fix adds the two missing spaces.Tests and Documentation
Added
test_format_story_prompt_separates_sentences, which asserts the rendered prompt separates the sentences at both joins and contains no gluedtextand. It fails on main and passes with the change. The existingtest_format_story_promptpasses unchanged since its assertions never spanned the joins.No documentation change needed, so I did not run JupyText.