{{ message }}
Repository navigation
FIX: stop temp file leak in remote dataset loader cache=False path - #2842
Merged
Roman Lutz (romanlutz) merged 2 commits intoSep 25, 2026
Conversation
With cache=False the loader wrote the fetched dataset to a NamedTemporaryFile(delete=False) and then immediately dropped the handle, abandoning a full copy of the data in the system temp directory on every fetch. Nothing read the file. Skip the pointless write; cache=False simply does not persist.
Roman Lutz (romanlutz)
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2841.
the fetched copy is written through a context-managed temp file and unlinked when the loader is done with it, so cache=False fetches stop stranding full dataset copies in the temp directory. same pattern as the #1894 fix for the audio path.
new test asserts no temp file survives a cache=False fetch. fails on main, passes here. loader suite 35/35 green, ruff clean.