Differentiate unset value from null value in OpenApiSchema.Const by Youssef1313 · Pull Request #2936 · microsoft/OpenAPI.NET · GitHub
Skip to content

Differentiate unset value from null value in OpenApiSchema.Const #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 8 commits into from
Jul 14, 2026
Merged

Differentiate unset value from null value in OpenApiSchema.Const #2936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
48e4b13
Differentiate unset value from null value in OpenApiSchema.Const
Youssef1313 Jul 13, 2026
aa8b400
Fix for ref
Youssef1313 Jul 13, 2026
0e7bec0
Fix default for
Youssef1313 Jul 13, 2026
f143034
Different approach
Youssef1313 Jul 14, 2026
4362730
Fix deserializing of const null
Youssef1313 Jul 14, 2026
6b91e2b
chore: update performance benchmark reports (#2)
Copilot Jul 14, 2026
2727d30
Merge branch 'main' into dev/ygerges/const
Youssef1313 Jul 14, 2026
73f7701
chore(benchmark): update benchmark reports
Copilot Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...ark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report-github.md
View file
Open in desktop
12 changes: 6 additions & 6 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Method,Job,AnalyzeLaunchVariance,EvaluateOverhead,MaxAbsoluteError,MaxRelativeError,MinInvokeCount,MinIterationTime,OutlierMode,Affinity,EnvironmentVariables,Jit,LargeAddressAware,Platform,PowerPlanMode,Runtime,AllowVeryLargeObjects,Concurrent,CpuGroups,Force,HeapAffinitizeMask,HeapCount,NoAffinitize,RetainVm,Server,Arguments,BuildConfiguration,Clock,EngineFactory,NuGetReferences,Toolchain,IsMutator,InvocationCount,IterationCount,IterationTime,LaunchCount,MaxIterationCount,MaxWarmupIterationCount,MemoryRandomization,MinIterationCount,MinWarmupIterationCount,RunStrategy,UnrollFactor,WarmupCount,Mean,Error,StdDev,Gen0,Gen1,Gen2,Allocated
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,490.9 μs,282.59 μs,15.49 μs,19.5313,3.9063,0.0000,321.99 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,203.9 μs,15.77 μs,0.86 μs,10.7422,1.9531,0.0000,183.85 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"884,972.5 μs","24,370.58 μs","1,335.83 μs",18000.0000,17000.0000,3000.0000,258042.35 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"284,350.7 μs","61,542.17 μs","3,373.33 μs",8000.0000,7000.0000,2000.0000,115210.25 KB
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,133,321.0 μs","304,160.14 μs","16,672.04 μs",30000.0000,18000.0000,3000.0000,454924.16 KB
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"547,652.0 μs","183,032.67 μs","10,032.64 μs",20000.0000,10000.0000,2000.0000,316687.77 KB
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,582.2 μs,208.61 μs,11.43 μs,19.5313,3.9063,0.0000,375.68 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,252.3 μs,29.46 μs,1.61 μs,11.7188,1.9531,0.0000,209.67 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,005,560.1 μs","211,112.24 μs","11,571.77 μs",22000.0000,18000.0000,3000.0000,311035.48 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"369,047.2 μs","94,799.88 μs","5,196.30 μs",9000.0000,8000.0000,2000.0000,140644.21 KB
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,241,432.6 μs","106,390.00 μs","5,831.60 μs",34000.0000,19000.0000,3000.0000,513301.23 KB
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"626,499.0 μs","70,802.74 μs","3,880.94 μs",22000.0000,10000.0000,2000.0000,345119.94 KB
16 changes: 8 additions & 8 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang='en'>
<head>
<meta charset='utf-8' />
<title>performance.Descriptions-20260712-124928</title>
<title>performance.Descriptions-20260714-121715</title>

<style type="text/css">
table { border-collapse: collapse; display: block; width: 100%; overflow: auto; }
Expand All @@ -14,7 +14,7 @@
<body>
<pre><code>
BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 7763 2.61GHz, 1 CPU, 4 logical and 2 physical cores
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.28 (8.0.28, 8.0.2826.26413), X64 RyuJIT x86-64-v3
Expand All @@ -26,12 +26,12 @@
<table>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
</tr>
</thead><tbody><tr><td>PetStoreYaml</td><td>490.9 &mu;s</td><td>282.59 &mu;s</td><td>15.49 &mu;s</td><td>19.5313</td><td>3.9063</td><td>-</td><td>321.99 KB</td>
</tr><tr><td>PetStoreJson</td><td>203.9 &mu;s</td><td>15.77 &mu;s</td><td>0.86 &mu;s</td><td>10.7422</td><td>1.9531</td><td>-</td><td>183.85 KB</td>
</tr><tr><td>GHESYaml</td><td>884,972.5 &mu;s</td><td>24,370.58 &mu;s</td><td>1,335.83 &mu;s</td><td>18000.0000</td><td>17000.0000</td><td>3000.0000</td><td>258042.35 KB</td>
</tr><tr><td>GHESJson</td><td>284,350.7 &mu;s</td><td>61,542.17 &mu;s</td><td>3,373.33 &mu;s</td><td>8000.0000</td><td>7000.0000</td><td>2000.0000</td><td>115210.25 KB</td>
</tr><tr><td>GHESNextYaml</td><td>1,133,321.0 &mu;s</td><td>304,160.14 &mu;s</td><td>16,672.04 &mu;s</td><td>30000.0000</td><td>18000.0000</td><td>3000.0000</td><td>454924.16 KB</td>
</tr><tr><td>GHESNextJson</td><td>547,652.0 &mu;s</td><td>183,032.67 &mu;s</td><td>10,032.64 &mu;s</td><td>20000.0000</td><td>10000.0000</td><td>2000.0000</td><td>316687.77 KB</td>
</thead><tbody><tr><td>PetStoreYaml</td><td>582.2 &mu;s</td><td>208.61 &mu;s</td><td>11.43 &mu;s</td><td>19.5313</td><td>3.9063</td><td>-</td><td>375.68 KB</td>
</tr><tr><td>PetStoreJson</td><td>252.3 &mu;s</td><td>29.46 &mu;s</td><td>1.61 &mu;s</td><td>11.7188</td><td>1.9531</td><td>-</td><td>209.67 KB</td>
</tr><tr><td>GHESYaml</td><td>1,005,560.1 &mu;s</td><td>211,112.24 &mu;s</td><td>11,571.77 &mu;s</td><td>22000.0000</td><td>18000.0000</td><td>3000.0000</td><td>311035.48 KB</td>
</tr><tr><td>GHESJson</td><td>369,047.2 &mu;s</td><td>94,799.88 &mu;s</td><td>5,196.30 &mu;s</td><td>9000.0000</td><td>8000.0000</td><td>2000.0000</td><td>140644.21 KB</td>
</tr><tr><td>GHESNextYaml</td><td>1,241,432.6 &mu;s</td><td>106,390.00 &mu;s</td><td>5,831.60 &mu;s</td><td>34000.0000</td><td>19000.0000</td><td>3000.0000</td><td>513301.23 KB</td>
</tr><tr><td>GHESNextJson</td><td>626,499.0 &mu;s</td><td>70,802.74 &mu;s</td><td>3,880.94 &mu;s</td><td>22000.0000</td><td>10000.0000</td><td>2000.0000</td><td>345119.94 KB</td>
</tr></tbody></table>
</body>
</html>
2 changes: 1 addition & 1 deletion performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json
View file
Open in desktop

Large diffs are not rendered by default.

62 changes: 31 additions & 31 deletions ...mark/BenchmarkDotNet.Artifacts/results/performance.EmptyModels-report-github.md
View file
Open in desktop
Loading